Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for Carousel #28

Closed
mccrodp opened this issue Mar 31, 2017 · 5 comments
Closed

Implement support for Carousel #28

mccrodp opened this issue Mar 31, 2017 · 5 comments
Assignees

Comments

@mccrodp
Copy link

mccrodp commented Mar 31, 2017

Hi, thanks for the work on this repo, I'm using it through this repo at the moment : https://github.com/mathieul/brunch-with-elm-bootstrap

I'm trying to simply output a free Boostrap theme using this package's boostrap .elm syntax and believe there maybe no slideshow / carousel element yet. I saw the Accordion, but no carousel.

Is this something on the roadmap or something you would accept via PR?

https://v4-alpha.getbootstrap.com/components/carousel/

@rundis
Copy link
Owner

rundis commented Mar 31, 2017

Yeah haven't gotten around to the carousel thing.
It's going to need to include some state and subscriptions I imagine. Not rocket science but not the simplest addition either.

Pull requests are cool, but it's a good idea to read the readme about rationale and goals for the library. Then if you think this is something you'd like to have a stab at, probably a good idea to startt off with a outline of how the api might look and comment here so that I can evaluate before spending too much time on implementation :-)

If you decide not to, it's tagged and will certainly be considered for implementation for a future release.

@rundis rundis changed the title Has Boostrap 4's Carousel been implemented yet? Implement support for Carousel Mar 31, 2017
@mccrodp
Copy link
Author

mccrodp commented Apr 3, 2017

Sounds like a good way to go, @rundis. I think I will postpone for now though as I don't need the slideshow directly, was more for a more complete showcase of outputting a Boostrap theme with Elm. Good to know it's on the roadmap, may revisit if I have time for a challenge. Thanks! 😄

@rundis
Copy link
Owner

rundis commented Apr 14, 2017

@folkertdev Would this be something you'd be interested in taking on ? Maybe more fun that just writing tests ? 😄

@folkertdev
Copy link
Collaborator

sure

@folkertdev folkertdev self-assigned this Apr 14, 2017
@folkertdev folkertdev mentioned this issue Apr 15, 2017
@rundis
Copy link
Owner

rundis commented May 28, 2017

Added and released in version 3.0.0.

@rundis rundis closed this as completed May 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants