Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar slide animation once in a while gets the wrong heigh #6

Closed
rundis opened this issue Jan 26, 2017 · 1 comment
Closed

Navbar slide animation once in a while gets the wrong heigh #6

rundis opened this issue Jan 26, 2017 · 1 comment

Comments

@rundis
Copy link
Owner

rundis commented Jan 26, 2017

To support the slide up/down effect I ended up wrapping the collabsible part in another div. Then I'm using debois/elm-dom on the collapse menu button click event to get the height of the hidden collapsed menu(-bar). Works most of the times, but sometimes it's getting the height of the element after the navbar which produces really funny animation results.

(also see #5)

@rundis
Copy link
Owner Author

rundis commented Feb 18, 2017

I think I managed to fix this one. The reason was that when clicking on the edge of the hamburger menu (navbar toggler), the target became the nav root item rather than the button. That messed up the logic for locating the element we need the height for to support the animation.

@rundis rundis closed this as completed Feb 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant