Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Improper identification of other maven-extensions without goals #11

Open
VenaNocta opened this issue Mar 5, 2024 · 0 comments · May be fixed by #13
Open

Bug: Improper identification of other maven-extensions without goals #11

VenaNocta opened this issue Mar 5, 2024 · 0 comments · May be fixed by #13
Labels
bug Something isn't working
Milestone
Release 1.1.0

Comments

@VenaNocta
Copy link
Member

Problem:
When r4m finds an extension which is missing its PluginDescripter file the crash is only logged but not counted in it's R4MLifecycleParticipant.unidentifiablePlugins collection.

Operation is not influenced by this but causes considerable console spam!

Solution:
Extensions discovered via R4MLifecycleParticipant.scanCoreExtensions() should not get logged when missing their PluginDescripter file.
@VenaNocta VenaNocta added the bug Something isn't working label Mar 5, 2024
@VenaNocta VenaNocta added this to the Release 1.1.0 milestone Mar 5, 2024
VenaNocta added a commit that referenced this issue May 26, 2024
@VenaNocta
fixed error log spam during detection of other extensions (resolves #11)
b1ee56c
@VenaNocta VenaNocta linked a pull request May 26, 2024 that will close this issue
RC v1.1.0 #13
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Release 1.1.0
1 participant
@VenaNocta