Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boosts plugin - Missing skills from boosts info #297

Closed
deathbeam opened this issue Dec 29, 2017 · 1 comment
Closed

Boosts plugin - Missing skills from boosts info #297

deathbeam opened this issue Dec 29, 2017 · 1 comment

Comments

@deathbeam
Copy link
Member

deathbeam commented Dec 29, 2017

Current included skills in the boosts plugin (in the BoostsOverlay.java)are:

	private static final Skill[] COMBAT = new Skill[]
	{
		Skill.ATTACK, Skill.STRENGTH, Skill.DEFENCE, Skill.RANGED, Skill.MAGIC
	};
	private static final Skill[] SKILLING = new Skill[]
	{
		Skill.COOKING, Skill.WOODCUTTING, Skill.FLETCHING, Skill.FISHING, Skill.FIREMAKING, Skill.CRAFTING,
		Skill.SMITHING, Skill.HERBLORE, Skill.AGILITY, Skill.THIEVING, Skill.SLAYER, Skill.FARMING, Skill.RUNECRAFT,
		Skill.HUNTER, Skill.CONSTRUCTION
	};

so there are in total 7 (6, not including Hitpoints) skills that are missing from the SKILLING list. For example Mining. The solution would be simply to add the missing skills to the SKILLING list and everything else should start working.

@deathbeam
Copy link
Member Author

Resolved in PR #303

Lucwousin referenced this issue in Lucwousin/runelite May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant