Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): Bump submodules and dependencies #521

Merged
merged 3 commits into from
Aug 9, 2023
Merged

build(deps): Bump submodules and dependencies #521

merged 3 commits into from
Aug 9, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 4, 2023

Automated changes by create-pull-request GitHub action

@ginglis13 ginglis13 closed this Aug 4, 2023
@ginglis13 ginglis13 reopened this Aug 4, 2023
@vsiravar
[create-pull-request] automated change
9d5ba2a 
Signed-off-by: GitHub <noreply@github.com>
@ginglis13 ginglis13 closed this Aug 7, 2023
@ginglis13 ginglis13 reopened this Aug 7, 2023
@pendo324
Copy link
Member

pendo324 commented Aug 7, 2023

Test failures seem to be because the default compose naming convention was changed containerd/nerdctl#1644

@ginglis13
Copy link
Contributor

ginglis13 commented Aug 8, 2023 •
edited

Another set of failures coming from containerd/nerdctl#2355, feature that allows for copying files in and out of stopped containers. Working on PR for these fixes in common-tests now

ginglis13 added a commit to ginglis13/common-tests that referenced this pull request Aug 8, 2023
@ginglis13
fix: make tests compatible with nerdctlv1.5
9584b81 
nerdctl released v1.5 and we saw some test regressions in
runfinch/finch#521:

* compose container suffix changed
* cp now works with stopped containers
* nested bind mounts issue resolved

Signed-off-by: Gavin Inglis <giinglis@amazon.com>
ginglis13 added a commit to ginglis13/common-tests that referenced this pull request Aug 8, 2023
@ginglis13
fix: make tests compatible with nerdctlv1.5
10f0759 
nerdctl released v1.5 and we saw some test regressions in
runfinch/finch#521:

* compose container suffix changed
* cp now works with stopped containers
* nested bind mounts issue resolved

Signed-off-by: Gavin Inglis <giinglis@amazon.com>
@ginglis13 ginglis13 mentioned this pull request Aug 8, 2023
Merged
1 task
ginglis13 added a commit to ginglis13/common-tests that referenced this pull request Aug 8, 2023
@ginglis13
fix: make tests compatible with nerdctlv1.5
1fd9f7b 
nerdctl released v1.5 and we saw some test regressions in
runfinch/finch#521:

* compose container suffix changed
* cp now works with stopped containers
* nested bind mounts issue resolved

Signed-off-by: Gavin Inglis <giinglis@amazon.com>
ginglis13 added a commit to ginglis13/common-tests that referenced this pull request Aug 8, 2023
@ginglis13
fix: make tests compatible with nerdctlv1.5
775eaa4 
nerdctl released v1.5 and we saw some test regressions in
runfinch/finch#521:

* compose container suffix changed
* cp now works with stopped containers
* nested bind mounts issue resolved

Signed-off-by: Gavin Inglis <giinglis@amazon.com>
ginglis13 added a commit to ginglis13/common-tests that referenced this pull request Aug 8, 2023
@ginglis13
fix: make tests compatible with nerdctlv1.5
af8e887 
nerdctl released v1.5 and we saw some test regressions in
runfinch/finch#521:

* compose container suffix changed
* cp now works with stopped containers
* nested bind mounts issue resolved

Signed-off-by: Gavin Inglis <giinglis@amazon.com>
ginglis13 added a commit to ginglis13/common-tests that referenced this pull request Aug 8, 2023
@ginglis13
fix: make tests compatible with nerdctlv1.5
1c6b27c 
nerdctl released v1.5 and we saw some test regressions in
runfinch/finch#521:

* compose container suffix changed
* cp now works with stopped containers
* nested bind mounts issue resolved

Signed-off-by: Gavin Inglis <giinglis@amazon.com>
ginglis13 added a commit to ginglis13/common-tests that referenced this pull request Aug 8, 2023
@ginglis13
fix: make tests compatible with nerdctlv1.5
a6b3e9f 
nerdctl released v1.5 and we saw some test regressions in
runfinch/finch#521:

* compose container suffix changed
* cp now works with stopped containers
* nested bind mounts issue resolved

Signed-off-by: Gavin Inglis <giinglis@amazon.com>
ginglis13 added a commit to runfinch/common-tests that referenced this pull request Aug 8, 2023
@ginglis13
fix: make tests compatible with nerdctlv1.5 (#75)
6876cd0 
*Description of changes:*

nerdctl released v1.5 and we saw some test regressions in
runfinch/finch#521:

* compose container suffix changed
* cp now works with stopped containers
* nested bind mounts issue resolved

Follow up PR after in finch to remove `FINCH_DOCKER_COMPAT` env
variable: runfinch/finch#418

Issue #, if available:



*Testing done:*

pulled down runfinch/finch#521 locally, `replace` directive to point to
local common-tests, `make test-e2e-container`

- [X] I've reviewed the guidance in CONTRIBUTING.md


#### License Acceptance

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

Signed-off-by: Gavin Inglis <giinglis@amazon.com>
@ginglis13
build(deps): bump runfinch/common-tests v0.7.2
d26455d 
Signed-off-by: Gavin Inglis <giinglis@amazon.com>
@ginglis13
Copy link
Contributor

Now seeing failures because of 1/ modified commit in finch version 2/ regression from containerd/nerdctl@11d80f2 that changed container list output to return as slice instead of individual string.

@ginglis13 ginglis13 force-pushed the create-pull-request/patch branch 2 times, most recently from cbeb40f to 795eca9 Compare August 8, 2023 21:15
@ginglis13 ginglis13 requested a review from a team August 8, 2023 21:59
pendo324
pendo324 previously approved these changes Aug 8, 2023
View reviewed changes
e2e/vm/additional_disk_test.go Outdated Show resolved Hide resolved
@ginglis13
fix: vm e2e tests nerdctl v1.5
89722b3 
nerdctl v1.5 introduced a change to output of container list operation
where container names are returned as a list/slice object rather than
string.

Signed-off-by: Gavin Inglis <giinglis@amazon.com>
@ginglis13 ginglis13 merged commit 1b3ad94 into main Aug 9, 2023
14 checks passed
@ginglis13 ginglis13 deleted the create-pull-request/patch branch August 9, 2023 02:57
@github-actions github-actions bot mentioned this pull request Aug 9, 2023
Merged
@ginglis13 ginglis13 mentioned this pull request Aug 10, 2023
Merged
1 task
KevinLiAWS pushed a commit that referenced this pull request Aug 16, 2023
@github-actions
chore(main): release 0.8.0 (#499)
ae6bb7d 
🤖 I have created a release *beep* *boop*
---


## [0.8.0](v0.7.0...v0.8.0)
(2023-08-16)


### Features

* adding config option for SOCI installation on VM
([#506](#506))
([a2e077b](a2e077b))


### Bug Fixes

* configure aws creds in sync submodules/deps action
([#518](#518))
([b67452e](b67452e))
* give pull request write permissions to sync job
([#520](#520))
([55b5235](55b5235))
* give token write perms to sync-submodules
([#519](#519))
([8b639ea](8b639ea))
* Mount /var/folders to finch vm
([#525](#525))
([c97d2e9](c97d2e9))
* option to use installed lima for SOCI e2e tests
([#533](#533))
([8b66659](8b66659))
* quote recursive calls to make
([#515](#515))
([d603096](d603096))
* Restart buildkit after containerd when provisioning
([#461](#461))
([fca1828](fca1828))


### Build System or External Dependencies

* **deps:** Bump github.com/docker/cli from 24.0.4+incompatible to
24.0.5+incompatible
([#495](#495))
([e9e8617](e9e8617))
* **deps:** Bump github.com/docker/docker from 24.0.4+incompatible to
24.0.5+incompatible
([#497](#497))
([6f1afbb](6f1afbb))
* **deps:** Bump github.com/lima-vm/lima from 0.16.0 to 0.17.2
([#531](#531))
([6e33d15](6e33d15))
* **deps:** Bump github.com/onsi/gomega from 1.27.8 to 1.27.10
([#496](#496))
([d08d102](d08d102))
* **deps:** Bump github.com/pkg/sftp from 1.13.5 to 1.13.6
([#530](#530))
([09b3846](09b3846))
* **deps:** Bump github.com/shirou/gopsutil/v3 from 3.23.6 to 3.23.7
([#513](#513))
([83bd718](83bd718))
* **deps:** Bump golang.org/x/tools from 0.11.0 to 0.11.1
([#509](#509))
([e826bcf](e826bcf))
* **deps:** Bump golang.org/x/tools from 0.11.1 to 0.12.0
([#523](#523))
([09d6514](09d6514))
* **deps:** Bump k8s.io/apimachinery from 0.27.3 to 0.27.4
([#487](#487))
([444bbc0](444bbc0))
* **deps:** Bump k8s.io/apimachinery from 0.27.4 to 0.28.0
([#535](#535))
([8df84cf](8df84cf))
* **deps:** Bump submodules and dependencies
([#521](#521))
([1b3ad94](1b3ad94))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ginglis13 ginglis13 ginglis13 left review comments

@pendo324 pendo324 pendo324 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pendo324 @ginglis13 @vsiravar