Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct typo in type name of struct (NerdctlClientOuput) #743

Merged
merged 1 commit into from
Feb 16, 2024
Merged

fix: Correct typo in type name of struct (NerdctlClientOuput) #743

merged 1 commit into from
Feb 16, 2024

Conversation

haytok
Copy link
Member

@haytok haytok commented Dec 22, 2023

Issue #, if available: N/A

Description of changes: Details are described in commit title and diff of the codes.

Testing done: Yes

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Hayato Kiwata <haytok@amazon.co.jp>
@weikequ weikequ closed this Feb 15, 2024
@weikequ weikequ reopened this Feb 15, 2024
Copy link
Contributor

@weikequ weikequ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just reran the tests again, and it seems like some of the recent errors we've been having. Thanks for the contribution!

@weikequ weikequ merged commit 13de2b9 into runfinch:main Feb 16, 2024
29 of 33 checks passed
@haytok haytok deleted the fix-typo-of-NerdctlClientOuput branch February 16, 2024 00:54
mharwani pushed a commit that referenced this pull request Feb 21, 2024
🤖 I have created a release *beep* *boop*
---


## [1.1.2](v1.1.1...v1.1.2)
(2024-02-20)


### Build System or External Dependencies

* **deps:** Bump github.com/docker/docker from 25.0.1+incompatible to
25.0.3+incompatible
([#799](#799))
([d761301](d761301))
* **deps:** Bump github.com/goccy/go-yaml from 1.11.2 to 1.11.3
([#780](#780))
([2e616ff](2e616ff))
* **deps:** Bump github.com/shirou/gopsutil/v3 from 3.23.12 to 3.24.1
([#787](#787))
([55f6d92](55f6d92))
* **deps:** Bump golang.org/x/crypto from 0.18.0 to 0.19.0
([#806](#806))
([3fbc87c](3fbc87c))
* **deps:** Bump golang.org/x/tools from 0.17.0 to 0.18.0
([#807](#807))
([7323751](7323751))
* **deps:** Bump k8s.io/apimachinery from 0.29.1 to 0.29.2
([#820](#820))
([6ca0f7f](6ca0f7f))
* **deps:** Bump submodules and dependencies
([#795](#795))
([ec77f1a](ec77f1a))
* **deps:** Bump submodules and dependencies
([#805](#805))
([0bf9148](0bf9148))


### Bug Fixes

* Correct typo in type name of struct (NerdctlClientOuput)
([#743](#743))
([13de2b9](13de2b9))
* Env variable CONTAINERD_SNAPSHOTTER cleared on overlayfs and ref…
([#816](#816))
([d222a34](d222a34))
* msi release tests cleanup
([#819](#819))
([0f23660](0f23660))
* stop Finch on uninstall
([#818](#818))
([a96788b](a96788b))
* **windows-installer:** add new cleanup script on install
([#824](#824))
([fccfa1d](fccfa1d))
* **windows-installer:** ignore FilesInUse/Restart dialogue
([#823](#823))
([f64835d](f64835d))
* **windows-installer:** uninstall script behavior
([#822](#822))
([ace37ea](ace37ea))


### Reverts

* "always force stop when using Virtualization.framework"
([#370](#370))
([cb3051e](cb3051e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants