Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removeLinkTag should replace all occurences of the css chunk #10

Closed
m5nv opened this issue May 15, 2019 · 4 comments
Closed

removeLinkTag should replace all occurences of the css chunk #10

m5nv opened this issue May 15, 2019 · 4 comments

Comments

@m5nv
Copy link

m5nv commented May 15, 2019

I hit on this while trying to get css preload to work in chrome and load normally in other browsers as suggested in a comment at SO.

The bug can be traced to this line.

The solution is to pass 'gi' parameter to RegExp object to find and 'remove' all occurrences of the chunk that needs to be inlined.

I fixed it locally and works for me. Cheers!

@runjuu
Copy link
Owner

runjuu commented May 15, 2019

Yes, we should. But seems that i is unnecessary in this case. 🤔️ Did I miss something?

@m5nv
Copy link
Author

m5nv commented May 16, 2019

Yes, we should. But seems that i is unnecessary in this case. thinking Did I miss something?

Doesn't hurt. Some folks like to use weird case for their tags. The html spec allows tag names and attribute names to be case-insensitive (at least the browsers don't seem to have issue with mixed case).

HTH.

@m5nv
Copy link
Author

m5nv commented May 29, 2019

Yes, we should. But seems that i is unnecessary in this case. thinking Did I miss something?

Doesn't hurt. Some folks like to use weird case for their tags. The html spec allows tag names and attribute names to be case-insensitive (at least the browsers don't seem to have issue with mixed case).

HTH.

@runjuu Any plans on doing a release with the fix any time soon? Thanks!

@runjuu runjuu closed this as completed in 832abae May 30, 2019
@runjuu
Copy link
Owner

runjuu commented May 30, 2019

@m5nv I'm sorry to have you keep waiting, 1.6.0 now is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants