Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Robo Tests without Robo script #165

Closed
ccjernigan opened this issue Aug 24, 2020 · 10 comments · Fixed by #177
Closed

Support for Robo Tests without Robo script #165

ccjernigan opened this issue Aug 24, 2020 · 10 comments · Fixed by #177

Comments

@ccjernigan
Copy link

This is an enhancement request to support robo tests without a robo script. Firebase Test Lab supports this, although it appears fladle does not. In the fladle source, the decision to do a robo test is based on the roboscript file path being non-null.

Issues sometimes come up with R8, ProGuard, or DexGuard that make robo testing the my release APK helpful in catching issues that might occur during first launch. However, DexGuard also obfuscates resource IDs which makes creating a roboscript for a release build much more difficult.

Being able to launch a robo test without a roboscript will enable my use case, but would also lower the barrier for others who want to run a robo test without recording a script.

@runningcode
Copy link
Owner

Oh, I didn't realize this was a use case. Thanks for reporting. Do you know if flank itself supports this?

@runningcode
Copy link
Owner

Yes, flank supports this but you must specify robo-directives is that your use case?

@ccjernigan
Copy link
Author

I was initially looking to effectively simulate prelaunch reports, without having to upload to Google Play. I've tried running this directly with the gcloud command without roboscript or robo-directives, which works.

Let me check on what's involved with robo-directives, because maybe an empty set of robo-directives would work.

@runningcode
Copy link
Owner

Is the fix in fladle to allow a roboDirective to be specified without specifying a roboScript or an instrumentation APK? I can do this relatively quickly if this is what is needed. Please confirm. Thanks!

@ccjernigan
Copy link
Author

I tried with flank, and it looks like it has a requirement that one of these be set:

java -jar flank.jar firebase test android run
version: v20.08.4
revision: 0b328fa775ebc69980b765b35a654089a6235d10

One of following options must be specified [test, robo-directives, robo-script].

I tried just setting fake robo-directives but it still would not run, so this looks like a limitation in flank currently.

@runningcode
Copy link
Owner

Ah, in that case, can you open an issue in the flank repository? Link it from here. It's likely we'll both need to make changes.

@ccjernigan
Copy link
Author

Flank/flank#1084

@ccjernigan
Copy link
Author

FYI the underlying Flank issue was just resolved 🎉

@pawelpasterz
Copy link
Contributor

@runningcode
If you are ok with that, I'd like to implement this feature for fladle

@runningcode
Copy link
Owner

Please do! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants