This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
[[ ColorDialogColors ]] implemented windows only global #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 17, 2013 11:04
…olors <custom colors> with the custom colors returned via the dialogData. Will investigate using a global colorDialogColors property.
…gColors Windows only. Added stubs for accessors on Linux. Implemented in a way that the data type of customDialogColors could be different depending on the platform: - Windows - list of colors, could be changed to numerically indexed array if required - Mac - when Cocoa dialog is implemented could be multi-dimensional array with root key of list name, child keys numerically indexed, grandchind keys name and color - Lunux - not yet investigated
…color_dialog_colors
| { | ||
| MCColor t_colors[16]; | ||
| char *t_colornames[16]; | ||
| uint8_t i; |
There was a problem hiding this comment.
It's better to just use an int / unsigned int for index vars.
|
Hi Monte, Thanks for this - it all looks fine apart from the potential for a small memory leak, as commented on above. Mark. |
…ged uint8_t to int
|
Hi Monte, All looks good - have merged into 'develop' via 'feature-color_dialog_colors' Thanks again! Mark. |
trevordevore
pushed a commit
to trevordevore/livecode
that referenced
this pull request
Jul 7, 2015
[[ PI ]] Add array editor using tree view widget
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.