Skip to content
This repository has been archived by the owner on Aug 31, 2021. It is now read-only.

Update clock.lcb #2056

Merged
merged 1 commit into from Jul 31, 2015
Merged

Update clock.lcb #2056

merged 1 commit into from Jul 31, 2015

Conversation

macMikey
Copy link
Contributor

Added fractional hours so the hour hand more closely resembles an analog clock.

@macMikey
Update clock.lcb
a5c73dd 
Added fractional hours so the hour hand more closely resembles an analog clock.
@peter-b peter-b self-assigned this Mar 13, 2015
@peter-b
Copy link
Contributor

peter-b commented Mar 13, 2015

Hi @macMikey, thank you for your contribution! Unfortunately, we won't be able to merge it until you've completed our Contributor License Agreement (CLA). Also unfortunately, the new website update this week means that our CLA webpage isn't currently available, but we'll be fixing it as soon as possible -- and when it's back up, either @runrevmark or I will get in touch and let you know. Thanks again!

@peter-b peter-b added the LCB label Mar 13, 2015
@peter-b
Copy link
Contributor

peter-b commented Jul 31, 2015

Hi @macMikey, you should now be able to sign the LiveCode Contributor's LiveCode agreement on the LiveCode website. Please see the information for contributors for more information. Let me know when you're all signed up. Thanks!

@macMikey
Copy link
Contributor Author

Done. NOW GET MY CODE IN THE CLOCK!!!

On Fri, Jul 31, 2015 at 4:32 AM, Peter TB Brett notifications@github.com
wrote:

Hi @macMikey https://github.com/macMikey, you should now be able to
sign the LiveCode Contributor's LiveCode agreement on the LiveCode website.
Please see the information for contributors
https://github.com/runrev/livecode/blob/develop/HACKING.md for more
information. Let me know when you're all signed up. Thanks!

—
Reply to this email directly or view it on GitHub
#2056 (comment).

@peter-b peter-b added this to the 8.0.0-dp-3 milestone Jul 31, 2015
@livecodeali
Copy link
Member

@livecode-vulcan review ok a5c73dd

@livecode-vulcan
Copy link
Contributor

💙 review by @livecodeali ok a5c73dd

livecode-vulcan added a commit that referenced this pull request Jul 31, 2015
@livecode-vulcan
Auto-merge pull request #2056 from macMikey/patch-2
95ce00f 
Update clock.lcb

Added fractional hours so the hour hand more closely resembles an analog clock.
@livecode-vulcan
Copy link
Contributor

😎 test success a5c73dd

livecodefraser added a commit that referenced this pull request Jul 31, 2015
@livecodefraser
Merge pull request #2056 from macMikey/patch-2
97a81c2 
Update clock.lcb
@livecodefraser livecodefraser merged commit 97a81c2 into livecode:develop Jul 31, 2015
@livecodefraser
Copy link
Contributor

Done!

@macMikey
Copy link
Contributor Author

Wow. I actually contributed something, lol.

On Fri, Jul 31, 2015 at 11:24 AM, Fraser Gordon notifications@github.com
wrote:

Merged #2056 #2056.

—
Reply to this email directly or view it on GitHub
#2056 (comment).

@peter-b
Copy link
Contributor

peter-b commented Jul 31, 2015

Please contribute something again soon! 👍

@mwieder
Copy link
Contributor

mwieder commented Aug 1, 2015

Mikey - congrats on getting the pull request accepted.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@peter-b peter-b

Labels
enhancement LCB vulcan/reviewed
Projects
None yet
Milestone
8.0.0-dp-3
6 participants
@macMikey @peter-b @livecodeali @livecode-vulcan @livecodefraser @mwieder