Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode Sidekick Plugin LogPoint Encoding And Visualization Issues #7

Closed
probably-not opened this issue Sep 6, 2022 · 3 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@probably-not
Copy link

I've added a LogPoint on a line that contains an exception (See #2 for the code example). The LogPoint logExpression is defined as {{exception.stack}}, which will output the exception stack for us to trace back to the original exception point.

The current output looks like this:

UnauthorizedException: Unauthorized at MixinAuthGuard.handleRequest (/app/node_modules/@nestjs/passport/dist/auth.guard.js:68:30) at /app/node_modules/@nestjs/passport/dist/auth.guard.js:49:128 at /app/node_modules/@nestjs/passport/dist/auth.guard.js:91:24 at allFailed (/app/node_modules/passport/lib/middleware/authenticate.js:110:18) at attempt (/app/node_modules/passport/lib/middleware/authenticate.js:183:28) at JwtStrategy.strategy.fail (/app/node_modules/passport/lib/middleware/authenticate.js:305:9) at JwtStrategy.authenticate (/app/node_modules/passport-jwt/lib/strategy.js:96:21) at attempt (/app/node_modules/passport/lib/middleware/authenticate.js:369:16) at authenticate (/app/node_modules/passport/lib/middleware/authenticate.js:370:7) at /app/node_modules/@nestjs/passport/dist/auth.guard.js:96:3 at new Promise (<anonymous>) at /app/node_modules/@nestjs/passport/dist/auth.guard.js:88:83 at MixinAuthGuard.<anonymous> (/app/node_modules/@nestjs/passport/dist/auth.guard.js:49:36) at Generator.next (<anonymous>) at fulfilled (/app/node_modules/@nestjs/passport/dist/auth.guard.js:17:58) at runMicrotasks (<anonymous>) at processTicksAndRejections (node:internal/process/task_queues:96:5)

It looks like there's an encoding (HTML encoding I think?) that's not being decoded properly in VSCode's visualization.

This is what it should look like when I decode it manually:

UnauthorizedException: Unauthorized at MixinAuthGuard.handleRequest (/app/node_modules/@nestjs/passport/dist/auth.guard.js:68:30) at /app/node_modules/@nestjs/passport/dist/auth.guard.js:49:128 at /app/node_modules/@nestjs/passport/dist/auth.guard.js:91:24 at allFailed (/app/node_modules/passport/lib/middleware/authenticate.js:110:18) at attempt (/app/node_modules/passport/lib/middleware/authenticate.js:183:28) at JwtStrategy.strategy.fail (/app/node_modules/passport/lib/middleware/authenticate.js:305:9) at JwtStrategy.authenticate (/app/node_modules/passport-jwt/lib/strategy.js:96:21) at attempt (/app/node_modules/passport/lib/middleware/authenticate.js:369:16) at authenticate (/app/node_modules/passport/lib/middleware/authenticate.js:370:7) at /app/node_modules/@nestjs/passport/dist/auth.guard.js:96:3 at new Promise (<anonymous>) at /app/node_modules/@nestjs/passport/dist/auth.guard.js:88:83 at MixinAuthGuard.<anonymous> (/app/node_modules/@nestjs/passport/dist/auth.guard.js:49:36) at Generator.next (<anonymous>) at fulfilled (/app/node_modules/@nestjs/passport/dist/auth.guard.js:17:58) at runMicrotasks (<anonymous>) at processTicksAndRejections (node:internal/process/task_queues:96:5)

@probably-not
Copy link
Author

Screenshot to show visualization problem:
image

@boroskoyo boroskoyo added the bug Something isn't working label Sep 6, 2022
@boroskoyo
Copy link
Contributor

Seems like we've missed a spot 👍 We'll fix this one asap

@hserefal
Copy link

hserefal commented Sep 8, 2022

Hi, we resolved the issue and published version v0.0.18 of our vscode extension. 🙂

@hserefal hserefal closed this as completed Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

3 participants