Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mismatched typing for nodejs agent #9

Closed
PhakornKiong opened this issue Aug 25, 2022 · 2 comments
Closed

Mismatched typing for nodejs agent #9

PhakornKiong opened this issue Aug 25, 2022 · 2 comments

Comments

@PhakornKiong
Copy link

While setting up the agent using code method in typescript, faced with this error.

image

In documentation page, it only mention that apiKey is required.
https://docs.runsidekick.com/installation/installing-agents/node.js/installation

In the typing for the config @runsidekick/sidekick-agent-nodejs/dist/config/ConfigNames.d.ts
image

That two variable should be made optional.
@bcaglayan
Copy link

Hello @PhakornKiong,

Thank you for your notice, we will mark these two config as optional on next version and notify to you

@serkan-ozal
Copy link

Hi @PhakornKiong ,
It has been fixed with the new version (0.0.12) of Sidekick Node.js agent.
Thanks for reporting the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@serkan-ozal @PhakornKiong @bcaglayan