Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not blow away existing attributeBindings #20

Merged
merged 3 commits into from Sep 14, 2016
Merged

Do not blow away existing attributeBindings #20

merged 3 commits into from Sep 14, 2016

Conversation

thoov
Copy link
Contributor

@thoov thoov commented Sep 13, 2016

No description provided.

@runspired
Copy link
Collaborator

Thanks! These are good changes/fixes :) One question, is this.applyStyles something you intend to be accessible for toggling? If so, we should probably use get on it when calculating the style string.

@runspired
Copy link
Collaborator

@thoov a change that could slide in here or a separate PR, for perf reasons I think the htmlSafe string should be a singleton; Basically this:

const SafeTouchAction = htmlSafe('touch-action: manipulation; -ms-touch-action: manipulation; cursor: pointer;');
const SafeEmptyString = htmlSafe('');

...

return applyStyle ? SafeTouchAction : SafeEmptyString;

@thoov
Copy link
Contributor Author

thoov commented Sep 13, 2016

@runspired I updated the PR to address your comments. I removed the applyStyles prop as I was simply coping it over from this pr. Let me know if you have any other comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants