Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [kprove] - Michelson Multisig Test Regression #2326

Open
sskeirik opened this issue Nov 15, 2021 · 1 comment
Open

[Bug] [kprove] - Michelson Multisig Test Regression #2326

sskeirik opened this issue Nov 15, 2021 · 1 comment
Labels

Comments

@sskeirik
Copy link
Contributor

Test Regression Information

The Michelson semantics has not been updated for a long time because some kprove tests would fail on newer versions of K.
In order to update the K submodule of K-Michelson, a few tests were disabled on CI.
We want to fix and re-enable these tests.
This issue contains information about how to run the tests (both the K versions and Michelson versions).

Here is the version information:

Prev K Submodule Commit/Version: bf17ff1 (v5.1.64)
Prev Michelson Commit (HEAD^): runtimeverification/michelson-semantics@ea0a99c

Curr K Submodule Commit/Version: b725ebd (v5.2.4)
Curr Michelson master Commit (HEAD): runtimeverification/michelson-semantics@d4b9cc89d

The test in question can be run on either Michelson commit by doing the following:

git clone https://github.com/runtimeverification/michelson-semantics/
cd michelson-semantics
git checkout <version-number>
git submodule update --init --recursive -- ext/k
make deps-k build-prove
make tests/proofs/multisig-spec.md.prove

In order to more easily test K-Michelson against both versions of K, I recommend checking out the michelson-semantics repo into two separate git worktrees.

Additional Info

This test made use of smt-lemma in a way that is no longer supported.
Either the usage of smt-lemma needs to be replaced or the semantics needs to be updated to properly support the modern smt-lemma restrictions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants