Never abstract KTokens (domain values), use subsort for code cell #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…traction * The cell abstraction mechanism serves to reduce AST _depth_, so it should not be necessary to abstract cells containing `KToken` instances. * In case of the `<code>` cell, this allows us to use the `ModuleDecl` sort instead of the supersort `Code` (which caused unnecessary branching)
virgil-serbanuta
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KTokeninstances.<code>cell, this allows us to use theModuleDeclsort instead of the supersortCode(which caused unnecessary branching)Also includes simplification equations for
updateMapto avoid failing on amissing hookerror in the backend.