Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[runwhen-local-feedback] Health Check for Namespaces in K8s or how to delete namespaces which are in terminating state #227

Open
zohebk8s opened this issue Jul 20, 2023 · 4 comments
Assignees

Comments

@zohebk8s
Copy link

Observation

Namespace Health Check in dashboard- A namespace can be in one of two phases: Active or Terminating

Possible Suggestions

I know it's a very basic health check. But usually, if the namespace is in "Terminating State" either it should not be displayed in runwhen dashboard or we need to provide a command to check the namespace health check/ how to delete the namespace which is in terminating state.

Any other details or context

Currently in my Azure AKS v1.25.6 cluster, I've deleted a few namespaces and it's in a terminating state. But in runwhen portal/dashboard, still I can see the data/details specific to those namespaces.

image image
@stewartshea
Copy link
Contributor

@zohebk8s

It's an interesting point, we could exclude Terminating from the scan/discovery, but I'm sure it's useful to see it come up if it's stuck. The Namespace Health Check does have a command that lists every resource tied to the namespace, with the idea that this command helps determine what is blocking the Termination. An example is here - Titled
"Get Listing Of Resources In Namespace"

Do you think that command would accomplish what you're looking for, and is incorrectly named? If not, we can talk about what else might be helpful.

@zohebk8s
Copy link
Author

It’s not a bug, just as an enhancement I’ve raised it here.

Firstly the namespace should be active. If it’s in terminating state, excluding it from the dashboard after particular interval of time is good(In my opinion). As the portal will be in a clean state without any unwanted statuses being displayed.

@stewartshea
Copy link
Contributor

Thanks for the feedback.

The nature of the tool is that if provides point-in-time discovery, and then completely regenerates the static documentation after the discovery process completes. If the namespaces were to successfully terminate after a subsequent scan, they would no longer show up in the documentation. If they were still in a terminating state after each scan (e.g. the default rescan period is 1800 seconds), then maybe they should still show up, since they are resources that are, well, producing a problem?

What are your thoughts there? I could possibly add a visual indicator to flag that they are terminating? or just completely omit them altogether?

@zohebk8s
Copy link
Author

Thank for sharing more details on how the application works(rescan part).

Just a thought and you might be having better idea about it. “Either display terminating namespaces as well in dashboard & provide commands on how to delete a namespace which is in terminating state(Before deleting the terminated namespace, validate the resources in that namespace. Or we can completely exclude it from the dashboard”

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants