Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move workspace builder generation rule definitions to the associated code bundles #247

Closed
stewartshea opened this issue Aug 15, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request Semver-Major Issues that need to be classified as Semver-Major for Release Notes

Comments

@stewartshea
Copy link
Contributor

This is currently tracked internally https://github.com/runwhen/platform-core/issues/1014 and duplicated here for public visibility.

Currently the generation rules (and associated templates) for the workspace builder are centralized in the workspace builder directory. This does not scale well and more immediately means that creating/editing the gen rules requires a new build of the runwhen local container image, which slows development turnaround time.

The plan is to move the gen rules into the code bundle directory associated with the gen rule. The directory structure will probably be that there's a "workspace-builder" at the top level of the code bundle and inside that directory there are "generation-rules" and "templates" subdirectories.

The workspace builder is configured with a set of code collections that it scans to collect all of the gen rules information across all of the code bundles in the code collections. Individual runs of the workspace builder can be configured (probably in the workspaceInfo.yaml file) to include additional code collections or suppress one or more of the default collections (or perhaps suppress individual code bundles in the included code collections).

The workspace builder tree will still contain the standard "common-labels.yaml" and "common-annotations.yaml" files that were added recently. The templating code in the workspace builder will include in the file search path both the directory for the templates that were downloaded from the code bundle plus the directory that contains the built-in standard templates.

Note: this ticket is for the code changes in the core workspace builder to support this feature. There's a separate ticket (https://github.com/runwhen/platform-core/issues/1017) for the task of actually reorganizing all of the existing gen rules to take advantage of this feature.

@stewartshea stewartshea added enhancement New feature or request Semver-Major Issues that need to be classified as Semver-Major for Release Notes labels Aug 15, 2023
@stewartshea stewartshea self-assigned this Aug 15, 2023
@stewartshea stewartshea assigned vaterlaus and unassigned stewartshea Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Semver-Major Issues that need to be classified as Semver-Major for Release Notes
Projects
Development

No branches or pull requests

2 participants