Upgrade code to PyTorch 0.4

[metro-smiles]

Hi,

I was wondering if you've planned to update this repo, to ensure compatible with PyTorch 0.4+, sometime soon?
This would be really helpful, since I have other modules in my repo that require PyTorch 0.4+.

[ruotianluo]

Try the self-critical.pytorch one. That is updated to 0.4 and contains everything this repo has.

[metro-smiles]

@ruotianluo, @dmitriy-serdyuk Has this repo now been ported to PyTorch 0.4 completely?

[ruotianluo]

I actually haven't tested it yet, you can give a try. I assume it's ok.

[metro-smiles]

I think the models folder needs updating

[metro-smiles]

Just tried, got the following error:
models/CaptionModel.py", line 50, in beam_step candidate_logprob = beam_logprobs_sum[q] + local_logprob RuntimeError: Expected object of type torch.FloatTensor but found type torch.cuda.FloatTensor for argument #3 'other'

[dmitriy-serdyuk]

Strange, it worked for me

[dmitriy-serdyuk]

How do you run it? I tested with pytorch 0.4.1 only, which version do you use?

[metro-smiles]

@dmitriy-serdyuk I used PyTorch 0.4.1 as well. Did you try using it (i.e. performing inference) on non-COCO images?

[metro-smiles]

@ruotianluo , @dmitriy-serdyuk Got it to work for pre-trained models but like I mentioned, had to update the scripts in the models folder...