-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
null test #67
Comments
Thanks, but I'm not sure if this is a valid assumption. |
It is just an extreme case test to see if these hashes works properly. if they do memory access, they will fail. xxh3 leaks its key if 0 byte string is processed. some hashes returns zero is key is zero at 0 byte, which is not so good. |
I think this is valid test, i.e. function should not read data when len = 0. For instance, t1ha2_atonce() pass avalanche test for len=0 (i.e. for seeds only) by https://github.com/demerphq/smhasher. |
When length is |
I'll add something like that. This is a cheap test for some edge cases. |
clhash FAIL
fasthash64 Imperfect
City64 Imperfect
MUM Imperfect
xxh3 Imperfect
t1ha2_atonce Imperfect
The text was updated successfully, but these errors were encountered: