Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on Activate when being asked to allow notifications #12

Closed
TomasHubelbauer opened this issue Jan 7, 2022 · 2 comments · Fixed by #13
Closed

Crash on Activate when being asked to allow notifications #12

TomasHubelbauer opened this issue Jan 7, 2022 · 2 comments · Fixed by #13

Comments

@TomasHubelbauer
Copy link
Contributor

Hi, I just got RSToDoList off the AppStore based on this GitHub repository. It looks great, but when I am asked to allow notifications during onboarding, when I click Activate, the app consistently crashes. But - the notifications do get enabled in the Settings it seems. I had do dismiss the prompt for notifications using the Not Now button for it to go away though, even though now in the Settings I see them enabled. The notifications work - I set a reminder and got a notification. Let me know how I can help debug the issue.

@rursache
Copy link
Owner

rursache commented Jan 7, 2022

Thanks for your report, I'll look into it in the following days. Meantime, you can help by creating a pull request if you can fix the issue yourself.

@TomasHubelbauer
Copy link
Contributor Author

Here is the stack trace of the issue I discovered while coming up with the fix:
image
I am not sure how to best display the stack trace so I will just post a screenshot of the stack unwinding:
image
Called from:
image
This is the first code site in your code, in OnboardingDataSource:
image
Called from AppDelegate:
image
I fixed this by just running that handler on the main thread no matter what.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants