Add "chrono" feature #3
Conversation
|
thanks for this PR! would it be possible for you to add the following things?
with that the feature will be complete and easily visible for everyone. |
|
Hey, I'd like to receive some help with |
|
This is the error message: |
|
Nevermind, fixed it myself. The solution has a lot of repetition though, couldn't think of a way to avoid it. |
.travis.yml
Outdated
| @@ -3,11 +3,14 @@ rust: | |||
| - stable | |||
| - 1.38.0 # lowest rust release against which we guarantee compatibility. | |||
| cache: cargo | |||
| env: | |||
| - CHRONO='--features "chrono"' | |||
There was a problem hiding this comment.
this isn't working because you quotes "chrono". you can test this yourself on a local shell by doing the same as travis-ci:
$ export CHRONO='--features "chrono"'
$ cargo build $CHRONO
error: Package `r2d2-oracle v0.2.0 (Z:\development\r2d2-oracle)` does not have these features: `"chrono"`
$ export CHRONO='--features chrono'
$ cargo build $CHRONO
Finished dev [unoptimized + debuginfo] target(s) in 1.32sThere was a problem hiding this comment.
Quotes worked on my machine (win 10) and that's how it's specified in the book. Maybe linux is different in that
There was a problem hiding this comment.
thanks a lot and sorry for the back-and-forth! i believe i now know how to get the travis build working as intended (with your original version of it). can you please do that change and also squash your commits so that there's a single commit containing the whole feature? otherwise i can also take care of that for you while merging if you want.
|
Is it ok now? |
|
Fixed the commit message |
| - cargo test --verbose | ||
| - cargo clippy --verbose | ||
| - cargo fmt && [ `git status -s | wc -l` -eq 0 ] # check that all files are formatted with `cargo fmt` | ||
| - cargo fmt && [ `git status -s | wc -l` -eq 0 ] # check that all files are formatted with `cargo fmt` |
There was a problem hiding this comment.
nit-picking: this is removing the final linebreak and wouldn't have been necessary... but we can keep it as-is, doesn't hurt, just doesn't look 100% nice.
|
i'll release this as a new version (0.3.0) hopefully tonight. |
rust-oracle crate provides a feature that adds various trait implementations for the chrono crate that are particularly useful when working with dates.
This PR adds chrono feature that enables the chrono feature in rust-oracle