Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen version requirement? #6

Closed
mlh758 opened this issue Jan 12, 2021 · 5 comments
Closed

Loosen version requirement? #6

mlh758 opened this issue Jan 12, 2021 · 5 comments

Comments

@mlh758
Copy link

mlh758 commented Jan 12, 2021

Would it be possible to change the oracle version listed in Cargo.toml to just "0.3"? It would be nice to be able to pull in new patch versions without having to wait for this library to update.

@rursprung
Copy link
Owner

this is not needed, cargo handles 0.3.1 the same way as ^0.3.1: https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html

thus any oracle version >= 0.3.1 and < 0.4 is acceptable and this library here doesn't need to be updated until oracle 0.4 or 1.0 comes out (in which case - according to semver - there will be breaking changes which might affect us).
we need an API introduced in 0.3.1 (see commit 117a291), thus we can't accept 0.3.0 and need to explicitly state this in the dependencies.

@mlh758
Copy link
Author

mlh758 commented Jan 13, 2021

Oh! I'm sorry about that, I misunderstood how the Cargo file specifies exact versions. Makes sense though.

@IdemenB
Copy link

IdemenB commented Apr 26, 2021

Hi @rursprung , thank your for this pooling library. I want to test both oracle and r2d2-oracle for our usecases and just noticed that oracle's version exceeded 0.5.0 (not it is 0.5.1.). Is that OK to update the dependency of your crate?

Additionaly, in the TODO list of the oracle crate they have "connection pooling" among others. Do they mean something else or are they not aware of this lib?

@rursprung
Copy link
Owner

the PR #9 should change the compatibility from oracle 0.4 to oracle 0.5. i just haven't had time to review & merge it + create a new release of this crate. i'll get to it in the coming days. until then you'll have to stick to oracle 0.4.

@rursprung
Copy link
Owner

i've now released r2d2-oracle v0.5.0 with support for oracle v0.5

Additionaly, in the TODO list of the oracle crate they have "connection pooling" among others. Do they mean something else or are they not aware of this lib?

i raised kubo/rust-oracle#33 for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants