Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to push some commits for Python 3.6 compatibility. #41

Open
jmbinette opened this issue Feb 22, 2018 · 2 comments
Open

Trying to push some commits for Python 3.6 compatibility. #41

jmbinette opened this issue Feb 22, 2018 · 2 comments

Comments

@jmbinette
Copy link

Not sure what I am doinhg wrong

@patrickjmcd
Copy link
Contributor

patrickjmcd commented Feb 22, 2018

It looks like you created a PR for it. It just needs to be accepted before it can be merged into the master branch. I did a quick test of the code and it looks like reading/writing REALS on a CompactLogix and on a Micro800 using the direct_connection=True parameter of c.open().

There are a few types implemented by the Micro800 that do not work (UDINT, for example) but I will work to test which ones don't work and implement fixes. These just seem to be missing from the PACK_DATA_FUNCTION and UNPACK_DATA_FUNCTION structures and associated functions in cip_base.py.

@patrickjmcd
Copy link
Contributor

patrickjmcd commented Feb 22, 2018

Your code, however, does not seem to be backwards compatible with python2

The open() function of cip_base fails with error Unknown format code 'x' for object of type 'str'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants