replace VR module with VR-discrete

[rusefillc]

remove VR module
add VR-discrete like on https://github.com/rusefi/hellen128mercedes
VR_analog should be connected to ADC3 pin, see hellen128merc

[rusefillc]

@mck1117 what is current requirement for THRESHOLD_VR? does it have to a low side channel or could it be just an stm32 pin?

https://github.com/andreika-git/hellen-one/wiki/module-output

[mck1117]

VR_analog not needed

Not true, this will eventually be required for configuration.

@mck1117 what is current requirement for THRESHOLD_VR? does it have to a low side channel or could it be just an stm32 pin?

It needs a PWM output directly from the MCU, no output module.

[rusefillc]

@mck1117 please elaborate
"analog" vs "configuration"
does it have to be an ADC pin or just any GPIO pin?

[rusefillc]

Some notes added to https://github.com/andreika-git/hellen-one/wiki/module-vr-discrete

[mck1117]

Analog in to the MCU will let you view the waveform from the sensor in real time, so you can set the threshold. Maybe completely automatic in the future.

The analog input to the MCU needs to be something on ADC3.

[rusefillc]

@mck1117 is there a chance that we are over-engineering here?

[mck1117]

This would be nice to do, since without the max992x we don't get automagic threshold:

https://www.maxxecu.com/webhelp/settings-diagnostics-trigger_oscilloscope.html

[rusefillc]

@mck1117 can you please pick where to connect VR_analog on hellen121vag?

[rusefillc]

[rusefillc]

Looks like depends/related to #49

[rusefillc]

Since we are removing old VR there is no need in input/output jumpers

[rusefillc]

VR_THRESHOLD could use any of the GPIO unused pins

E23 E11 etc

[mck1117]

VR_THRESHOLD could use any of the GPIO unused pins

E23 E11 etc

No, VR_THRESHOLD needs a hardware PWM pin from the STM32. It's in theory possible with soft PWM, but faster hardware PWM does make a big difference there.

[rusefillc]

ok, on this board we can move idle