Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "Some of the required fields are not found in the log" message softer #126

Open
rusefillc opened this issue Jul 20, 2021 · 1 comment
Assignees

Comments

@rusefillc
Copy link
Contributor

Current message is misleading because field is not really REQUIRED for upload to be successful.

In my opinion we should remove the message from the before-upload button in order to not scare users away like at https://rusefi.com/forum/viewtopic.php?p=41631#p41631

if we want to display any "for your information" we shall display it AFTER the log was uploaded

image

@rusefillc
Copy link
Contributor Author

This is probably related to rusefi/rusefi#1627 @mck1117

Instead of engine_load we now have two separate

entry = fuelingLoad, @@GAUGE_NAME_FUEL_LOAD@@, float, "%.1f"
entry = ignitionLoad, @@GAUGE_NAME_IGNITION_LOAD@@, float, "%.1f"

open question which of these should be applied here

as a quick compatibility fix can we rename fuelingLoad into engine_load?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants