-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugin upload return code is not json #76
Comments
Where is signature? The signature is required to upload the tune. |
My bad on signature, will fix. @andreika-git do we want better error handling in php to produce a more readable error message? only if that's not too much trouble |
@stefanst reports I've just changed plugin to actually display the PHP notice let's see what would it be this time |
let's please explicitly check this condition and return valid JSON error if no .ini file? also I think I see the file in https://rusefi.com/online/ini/rusefi/2020/08/08/mre_f4/ what's going on here @andreika-git ? |
@stefanst please attach tune to this ticket |
Offending tune attached |
It's a funny bug we've inherited from the old msqur behavior for MS signatures: "//If there's a decimal, remove any trailing zeros." |
trying to upload attached tunes, something does not go well, http content is not helpful and not JSon :(
The text was updated successfully, but these errors were encountered: