Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grunt task #20

Closed
lordfpx opened this issue Oct 20, 2014 · 8 comments
Closed

Grunt task #20

lordfpx opened this issue Oct 20, 2014 · 8 comments

Comments

@lordfpx
Copy link

lordfpx commented Oct 20, 2014

Hello,

Would it be difficult to do a grunt task?

@Rush
Copy link
Owner

Rush commented Oct 20, 2014

Probably easy, I accept pull requests :)

@lordfpx
Copy link
Author

lordfpx commented Oct 20, 2014

If I knew how to do that, that would be a pleasure to send a PR ;-)

@Rush
Copy link
Owner

Rush commented Oct 20, 2014

What exactly do you want to do with grunt?

@lordfpx
Copy link
Author

lordfpx commented Oct 20, 2014

We need to automate project building using NPM, Bower and Grunt. We are using Font awesome, unfortunately, icons can't be displayed when printing on old Opera versions, Sogou (Chinese browser) and badly on IE8. The only solution is to provide for a PNG fallback.

Grunt copy, compile Less, concat JS, copy files... Now we need to generate PNG for font awesome icons.
As it's a huge project with changing developers, things has to be automated.

@Rush
Copy link
Owner

Rush commented Oct 20, 2014

You can generate them once and commit to your repo as PNGs. Also, the repo provides pre-generated version of black and white pngs.

@lordfpx
Copy link
Author

lordfpx commented Oct 20, 2014

Yes that what we will do I think. Thank you!

@shobhitg
Copy link

Also Font Awesome maintainers aren't very keen on adding very many fonts going forward.

People +1 requests on Font Awesome everyday, but to no avail (FortAwesome/Font-Awesome#492).

Infact, they have clearly stated that they are not accepting any pull requests: https://github.com/FortAwesome/Font-Awesome/blob/master/CONTRIBUTING.md#pull-requests

And rightly so, If FA would keep adding fonts left and right then it would become humongous very soon. And that is where Font Custom comes in (https://github.com/FontCustom/fontcustom).

@dominykas
Copy link
Contributor

There already are two packages that work as grunt tasks:
https://www.npmjs.com/package/grunt-font-awesome-svg
https://www.npmjs.com/package/grunt-font-awesome-svg-png

No clue why aren't they using this lib as a dependency.

@Rush Rush closed this as completed May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants