Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asking users for opinion - padding or not? #68

Open
Rush opened this issue May 29, 2017 · 1 comment
Open

Asking users for opinion - padding or not? #68

Rush opened this issue May 29, 2017 · 1 comment

Comments

@Rush
Copy link
Owner

Rush commented May 29, 2017

Do you think Font-Awesome-SVG-PNG should try to put icons in a square by adding padding or keep it faithful to the original sizes?

For example http://fontawesome.io/icon/building/ and http://fontawesome.io/icon/building-o/ have a different width and forcing padding to make them square can have some alignment issues.

But I would still icons http://fontawesome.io/icon/battery-full/ as kind of an exception as they have wildly bigger width.

@Rush
Copy link
Owner Author

Rush commented May 30, 2017

Newest versions adds some vertical padding for pixel perfection but only up to 16 / 14 of the original size. If icon was originally square, the same padding will be applied to keep it square.

Feedback welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant