Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use trait collection to decide which form of weekday symbols should be used #68

Closed
xhacker opened this issue Jun 15, 2015 · 8 comments
Closed

Comments

@xhacker
Copy link

xhacker commented Jun 15, 2015

Currently RSDayFlow uses isPhone and isPortraitInterfaceOrientation to decide the form of weekday symbols. It mostly fine, but has problems when the view is in split view.

screen shot 2015-06-15 at 11 03 04 am

The best way is to use trait collection. However it requires iOS 8. Another workaround is to use the width of the view. Thoughts?

@ruslanskorb
Copy link
Owner

We can try to have another look at this PR or add support for trait collection on devices with iOS 8+.

@ruslanskorb
Copy link
Owner

Hi @xhacker,
Are you planning to make any PR for this?

@xhacker
Copy link
Author

xhacker commented Jun 18, 2015

Is it acceptable to support only iOS 8+?

@xhacker
Copy link
Author

xhacker commented Jun 18, 2015

I just looked at this PR and realized it's very flexible. I could make a PR based on that without using trait collection. But I don't have time until this weekend.

@ruslanskorb
Copy link
Owner

Okay, I'll do it myself.

@xhacker
Copy link
Author

xhacker commented Jun 18, 2015

Okay, thanks!

@ruslanskorb
Copy link
Owner

No probs!

@xhacker
Copy link
Author

xhacker commented Jun 29, 2015

Awesome, thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants