New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use trait collection to decide which form of weekday symbols should be used #68
Comments
We can try to have another look at this PR or add support for trait collection on devices with iOS 8+. |
Hi @xhacker, |
Is it acceptable to support only iOS 8+? |
I just looked at this PR and realized it's very flexible. I could make a PR based on that without using trait collection. But I don't have time until this weekend. |
Okay, I'll do it myself. |
Okay, thanks! |
No probs! |
Awesome, thanks! 👍 |
Currently RSDayFlow uses
isPhone
andisPortraitInterfaceOrientation
to decide the form of weekday symbols. It mostly fine, but has problems when the view is in split view.The best way is to use trait collection. However it requires iOS 8. Another workaround is to use the width of the view. Thoughts?
The text was updated successfully, but these errors were encountered: