Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to select a date range #73

Closed
wants to merge 3 commits into from

Conversation

aryaxt
Copy link
Contributor

@aryaxt aryaxt commented Jul 5, 2015

Note: because the delegate method for date range can have a null second date, I had to add nullability to the delegate method in order support Swift, and that required adding nullability to all methods and properties in the header file

Still doing some cleanup, will post a comment when it's ready

@aryaxt aryaxt force-pushed the master branch 6 times, most recently from 8315067 to 0834058 Compare July 5, 2015 17:05
@aryaxt
Copy link
Contributor Author

aryaxt commented Jul 5, 2015

@ruslanskorb This is good for review

@ruslanskorb
Copy link
Owner

@aryaxt Thanks!
I'll think about better names for dates of the selected range.
I would like to change the default look of the selected range to something like this:

selected_date_range

Can we do it?

@aryaxt
Copy link
Contributor Author

aryaxt commented Jul 5, 2015

Should be fine will look into it. Just wondering if it would look weird if the selection contains 2 months. Will give it a shot.

Build is failing because travis is running on an older version of Xcode.

@ruslanskorb
Copy link
Owner

@aryaxt I'll be glad to see it.
You don't need to worry about Travis, I know.

@ruslanskorb ruslanskorb added this to the 1.1.0 milestone Jul 5, 2015
@aryaxt
Copy link
Contributor Author

aryaxt commented Jul 7, 2015

This is definitely trickier than I thought. Will look into it again this weekend.
I think it would be nice to allow both styles, grouped-date-range and separated-date-range

@ruslanskorb ruslanskorb removed this from the 1.1.0 milestone Jul 19, 2015
@aryaxt
Copy link
Contributor Author

aryaxt commented Jul 19, 2015

@ruslanskorb Any thought on merging this the way it looks like and adding a second theme to have the date ranges grouped (similar to screen shot above) on a separate PR/version?

My design requirement is the way I have it in the PR, and haven't had time to work on the grouped date range theme. Let me know so that I know whether I should wait for this to get merged or use my fork for range picking.

Thanks

@ruslanskorb
Copy link
Owner

Hi @aryaxt!
Unfortunately, at the moment I do not have time to thoroughly go through this PR. I want to merge it some later and release a new version with it and the grouped date ranges.
Thanks!

@aryaxt
Copy link
Contributor Author

aryaxt commented Jul 19, 2015

ok awesome, will keep this open and point to my branch till you review

Conflicts:
	RSDayFlow/RSDFDatePickerDayCell.h
	RSDayFlow/RSDFDatePickerDayCell.m
	RSDayFlow/RSDFDatePickerView.m
@aryaxt
Copy link
Contributor Author

aryaxt commented Oct 23, 2015

Thanks for the awesome library
My new requirements are very specific to the app I'm building so won't make sense to add them here, will continue on my fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants