New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ability to select a date range #73
Conversation
- Updated code based on code review
8315067
to
0834058
Compare
@ruslanskorb This is good for review |
@aryaxt Thanks! Can we do it? |
Should be fine will look into it. Just wondering if it would look weird if the selection contains 2 months. Will give it a shot. Build is failing because travis is running on an older version of Xcode. |
@aryaxt I'll be glad to see it. |
This is definitely trickier than I thought. Will look into it again this weekend. |
@ruslanskorb Any thought on merging this the way it looks like and adding a second theme to have the date ranges grouped (similar to screen shot above) on a separate PR/version? My design requirement is the way I have it in the PR, and haven't had time to work on the grouped date range theme. Let me know so that I know whether I should wait for this to get merged or use my fork for range picking. Thanks |
Hi @aryaxt! |
ok awesome, will keep this open and point to my branch till you review |
Conflicts: RSDayFlow/RSDFDatePickerDayCell.h RSDayFlow/RSDFDatePickerDayCell.m RSDayFlow/RSDFDatePickerView.m
Thanks for the awesome library |
Note: because the delegate method for date range can have a null second date, I had to add nullability to the delegate method in order support Swift, and that required adding nullability to all methods and properties in the header file
Still doing some cleanup, will post a comment when it's ready