Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Komac incorrectly using arm64 binary for x64 architecture #200

Closed
1 task done
sitiom opened this issue May 18, 2023 · 3 comments
Closed
1 task done

[Bug]: Komac incorrectly using arm64 binary for x64 architecture #200

sitiom opened this issue May 18, 2023 · 3 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@sitiom
Copy link

sitiom commented May 18, 2023

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

https://github.com/ArmCord/ArmCord/actions/runs/4972653487/jobs/8897984711

Executing command: java -jar komac.jar update --id 'ArmCord.ArmCord' --version 3.2.0 --urls 'https://github.com/ArmCord/ArmCord/releases/download/v3.2.0/ArmCord.Setup.3.2.0.ARM64.exe,https://github.com/ArmCord/ArmCord/releases/download/v3.2.0/ArmCord.Setup.3.2.0.exe' --submit
  CI environment detected! Komac will throw errors instead of prompting on invalid input
  Found ArmCord.ArmCord in the winget-pkgs repository
  Found latest version: 3.1.7
  # Created with WinGet Releaser v2 using Komac v1.6.0
  # yaml-language-server: $schema=https://aka.ms/winget-manifest.installer.1.4.0.schema.json
  
  PackageIdentifier: ArmCord.ArmCord
  PackageVersion: 3.2.0
  InstallerType: nullsoft
  Scope: user
  UpgradeBehavior: install
  ReleaseDate: 2023-05-[14](https://github.com/ArmCord/ArmCord/actions/runs/4972653487/jobs/8897984711#step:2:15)
  Installers:
  - Architecture: x64
    InstallerUrl: https://github.com/ArmCord/ArmCord/releases/download/v3.2.0/ArmCord.Setup.3.2.0.ARM64.exe
    InstallerSha256: 8AB84F27C7284E0FC55E549CED81DD9B8AE2EB9FD[20](https://github.com/ArmCord/ArmCord/actions/runs/4972653487/jobs/8897984711#step:2:21)4DC44614835929C7DE9DE
  - Architecture: arm64
    InstallerUrl: https://github.com/ArmCord/ArmCord/releases/download/v3.2.0/ArmCord.Setup.3.2.0.ARM64.exe
    InstallerSha[25](https://github.com/ArmCord/ArmCord/actions/runs/4972653487/jobs/8897984711#step:2:26)6: 8AB84F[27](https://github.com/ArmCord/ArmCord/actions/runs/4972653487/jobs/8897984711#step:2:28)C7[28](https://github.com/ArmCord/ArmCord/actions/runs/4972653487/jobs/8897984711#step:2:29)4E0FC55E549CED81DD9B8AE2EB9FD204DC446148359[29](https://github.com/ArmCord/ArmCord/actions/runs/4972653487/jobs/8897984711#step:2:30)C7DE9DE
  ManifestType: installer
  ManifestVersion: 1.4.0

The second URL doesn't get used, and the arm64 link was incorrectly provided in the x64 arch.

@russellbanks
Copy link
Owner

Thanks for reporting! This will be the installer matching when used in parameters. Arm64 and x64 both have 64 so that's where it'll have gotten confused. I'll look into it as an edge case :)

@russellbanks
Copy link
Owner

russellbanks commented May 18, 2023

@sitiom Komac internally detects them both as arm because of the arm in ArmCord 😭

@russellbanks
Copy link
Owner

russellbanks commented May 18, 2023

I've fixed this by changing the Regex to look for a delimiter before and after the architecture (. or -). This means that the Arm in ArmCord is not detected because it's part of a bigger word, rather than something that is more obviously an architecture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants