Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: No longer shows link to created pull request #133

Closed
1 task done
sitiom opened this issue Mar 14, 2023 · 1 comment · Fixed by #134
Closed
1 task done

[Bug]: No longer shows link to created pull request #133

sitiom opened this issue Mar 14, 2023 · 1 comment · Fixed by #134
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@sitiom
Copy link

sitiom commented Mar 14, 2023

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

When running Komac update, Komac should show a link to the pull request at the end of the command:
image

However, this is no longer showing in the latest version. Example with https://github.com/LGUG2Z/whkd/actions/runs/4411818940/jobs/7730689700:
image
Despite that, the PR is successfully created: microsoft/winget-pkgs#99400

@sitiom sitiom added bug Something isn't working help wanted Extra attention is needed labels Mar 14, 2023
@russellbanks
Copy link
Owner

Sorry about this - I extracted the part that prints the link to the pull request from the function that creates the pull request so that it had less dependencies and was easier to test, but forgot to add it back in when the --submit flag has not been used (which winget releaser uses). It should still print that when --submit is not used.

Fixed in #134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants