Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Gradle Toolchain to pin JDK version #318

Closed
Okeanos opened this issue Oct 11, 2023 · 0 comments · Fixed by #348
Closed

Use Gradle Toolchain to pin JDK version #318

Okeanos opened this issue Oct 11, 2023 · 0 comments · Fixed by #348

Comments

@Okeanos
Copy link

Okeanos commented Oct 11, 2023

While poking around the project I noticed that the build.gradle.kts declares the the Java compatibility but doesn't enforce a consistent JVM environment.

Gradle offers Toolchains to ensure that projects can be build correctly with the expected JVM compile environment.

In order to improve reproducibility of the builds and make build requirements clearer, Gradle allows configuring toolchains on both project and task levels.

Unless there are specific reasons that I fail to see I would suggest adding such a declaration to make working with the project source code a little more robust.


Addendum: I would also suggest switching away from sourceCompatibility/targetCompatibility to release instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant