[Bug]: Cannot use space in package version

[Ubujira]

Is there an existing issue for this?

• I have searched the existing issues

What happened?

7zip-zstd manifest uses versioning in the format of "7-Zip-Version ZS vZstandard version R(n)".
The latest release on GitHub would be "22.01 ZS v1.5.5 R3" in that format, but Komac doesn't allow it presumably due to the space characters.

Possible relevant issue that could cause another issue microsoft/winget-create#498

Command
komac update -i mcmilk.7zip-zstd -v "22.01 ZS v1.5.5 R3" -u https://github.com/mcmilk/7-Zip-zstd/releases/download/v22.01-v1.5.5-R3/7z22.01-zstd-x64.exe https://github.com/mcmilk/7-Zip-zstd/releases/download/v22.01-v1.5.5-R3/7z22.01-zstd-x32.exe https://github.com/mcmilk/7-Zip-zstd/releases/download/v22.01-v1.5.5-R3/7z22.01-zstd-arm64.exe https://github.com/mcmilk/7-Zip-zstd/releases/download/v22.01-v1.5.5-R3/7z22.01-zstd-arm.exe

Output

error: invalid value '22.01 ZS v1.5.5 R3' for '--version <package_version>': Illegal Versioning: 22.01 ZS v1.5.5 R3

[rasa]

I'm seeing this issue with smartmontools.smartmontools which has 7.3 2022-02-28 r5338 (sf-7.3-1) as its version.

Running:

>komac update --identifier smartmontools.smartmontools ^
-v "7.4 2023-08-01 r5530 (sf-7.4-1)" ^
--urls "https://sourceforge.net/projects/smartmontools/files/smartmontools/7.4/smartmontools-7.4-1.win32-setup.exe/download" ^
--submit

returned:

error: invalid value '7.4 2023-08-01 r5530 (sf-7.4-1)' for '--version <package_version>': 
Illegal Versioning: 7.4 2023-08-01 r5530 (sf-7.4-1)

Sigcheck reports

>sigcheck smartmontools-7.4-1.win32-setup.exe

Sigcheck v2.90 - File version and signature viewer
Copyright (C) 2004-2022 Mark Russinovich
Sysinternals - www.sysinternals.com

smartmontools-7.4-1.win32-setup.exe:
        Verified:       Unsigned
        Link date:      9:58 PM 8/14/2022
        Publisher:      n/a
        Company:        www.smartmontools.org
        Description:    SMART Monitoring Tools
        Product:        smartmontools
        Prod version:   7.4.0.5530
        File version:   7.4.0.5530
        MachineType:    32-bit

So I tried

>komac update -i smartmontools.smartmontools ^
-v "7.4.0.5530" ^
--urls "https://sourceforge.net/projects/smartmontools/files/smartmontools/7.4/smartmontools-7.4-1.win32-setup.exe/download" ^
--submit

but received:

Error:
   0: ←[91msmartmontools.smartmontools does not exist in microsoft/winget-pkgs←[0m
   1: ←[91mNo files were found for manifests/s/smartmontools/smartmontools←[0m

[vedantmgoyal9]

Use komac new instead of komac update

[russellbanks]

I reported this in fosskers/rs-versions#23. There'll hopefully be a fix for this soon.

[rasa]

Use komac new instead of komac update

> komac --version
komac 2.0.4
> komac new -i smartmontools.smartmontools ^
-v "7.4.0.5530" ^
--urls "https://sourceforge.net/projects/smartmontools/files/smartmontools/7.4/smartmontools-7.4-1.win32-setup.exe/download" ^
--submit

retured

Error:
   0: Unsupported file extension    

I also tried

> komac new -i smartmontools.smartmontools ^
-v "7.4.0.5530" ^
--urls "https://sourceforge.net/projects/smartmontools/files/smartmontools/7.4/smartmontools-7.4-1.win32-setup.exe/download#/smartmontools-7.4-1.win32-setup.exe" ^
--submit

but got the same error.