Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please do not use custom Debug #76

Open
lu-zero opened this issue Jan 22, 2021 · 2 comments
Open

Please do not use custom Debug #76

lu-zero opened this issue Jan 22, 2021 · 2 comments

Comments

@lu-zero
Copy link
Contributor

lu-zero commented Jan 22, 2021

The current custom implementations make much harder to debug since useful information stays omitted.

If you are fine with it, I can send a PR that either removes or changes the current impls to Display.
@russelltg
Copy link
Owner

I'm happy to change my custom debugs to include the info you want, but the default debug for packets are huge and noisy, so I made it a bit easier to read.

@lu-zero
Copy link
Contributor Author

lu-zero commented Jan 23, 2021

The peer_addr would had been nice to have, but in general it was not really nice when I had to dump the packet for writing the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lu-zero @russelltg