Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Category selector doesn't work properly at various resolutions #2

Closed
russkev opened this issue Jan 19, 2022 · 0 comments · Fixed by #3
Closed

Category selector doesn't work properly at various resolutions #2

russkev opened this issue Jan 19, 2022 · 0 comments · Fixed by #3

Comments

@russkev
Copy link
Owner

russkev commented Jan 19, 2022

At the moment, the site thinks that 'food' should be selected even if there is just a hint of the food card being on screen. This means that if the resolution is such that even when scrolled all the way to the left, a food card is still visible, it will not let the drinks menu item appear highlighted, effectively breaking the selector.

The solution is to have it so that the food item has to be at least half way across the visible area to trigger the menu to be in the 'food' selection mode.

@russkev russkev mentioned this issue Jan 19, 2022
@russkev russkev linked a pull request Jan 21, 2022 that will close this issue
@russkev russkev linked a pull request Jan 21, 2022 that will close this issue
@russkev russkev closed this as completed Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant