Added option field for custom nim arguments #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluenote10
commented
Jan 11, 2017
| @@ -111,16 +117,17 @@ module.exports = | |||
| nimSuggestExe: fixSystemPath(atom.config.get('nim.nimsuggestExecutablePath') or 'nimsuggest') | |||
| nimExe: fixSystemPath(atom.config.get('nim.nimExecutablePath') or 'nim') | |||
| nimSuggestEnabled: atom.config.get 'nim.nimsuggestEnabled' | |||
| nimCustomArgs: parseArguments(atom.config.get('nim.nimCustomArguments') or '') | |||
There was a problem hiding this comment.
I probably could have handled this more elegantly, but I wasn't sure what value Atom provides by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple implementation of adding a configuration field for custom arguments. Closes #12
The implementation isn't perfect, because it simply splits the configuration string on whitespace to separate the individual arguments. I.e., it would fail on
--passL:"some arg with spaces". Fortunately, the most frequent arguments do not have spaces.Note: This is the first time I'm writing coffeescript / hacking in Atom, so a closer look to the pull request would be appreciated.