Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use customElements.define instead of document.registerElement #31

Open
ottok opened this issue Sep 23, 2023 · 0 comments
Open

Use customElements.define instead of document.registerElement #31

ottok opened this issue Sep 23, 2023 · 0 comments

Comments

@ottok
Copy link

ottok commented Sep 23, 2023

I am using this package in Pulsar and noticed that deprecations cop is nagging about:

Use customElements.define instead of document.registerElement see https://javascript.info/custom-elements

HTMLDocument.registerElement - file:///opt/Pulsar/resources/app.asar/static/index.js:100:12
Object.<anonymous> - [/home/otto/.pulsar/packages/nim/lib/nim-status-bar-view.coffee:75:29](https://github.com/home/otto/.pulsar/packages/nim/lib/nim-status-bar-view.coffee:75:29)
Object.<anonymous> - [/home/otto/.pulsar/packages/nim/lib/nim-status-bar-view.coffee:80:4](https://github.com/home/otto/.pulsar/packages/nim/lib/nim-status-bar-view.coffee:80:4)
Object.<anonymous> - [/home/otto/.pulsar/packages/nim/lib/nim-status-bar-view.coffee:84:3](https://github.com/home/otto/.pulsar/packages/nim/lib/nim-status-bar-view.coffee:84:3)
Module._compile - [/opt/Pulsar/resources/app.asar/src/native-compile-cache.js:120:30](https://github.com/opt/Pulsar/resources/app.asar/src/native-compile-cache.js:120:30)
Object..coffee - [/opt/Pulsar/resources/app.asar/src/compile-cache.js:252:23](https://github.com/opt/Pulsar/resources/app.asar/src/compile-cache.js:252:23)

Not a priority but you might want to address this at some point.

Thanks for a great plugin that helps me learn Nim faster! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant