Don't fail changelog generation on missing PRs

rust-lang · Jun 12, 2023 · a4407b4 · a4407b4
1 parent d567091
commit a4407b4
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/xtask/src/release/changelog.rs b/xtask/src/release/changelog.rs
@@ -30,14 +30,14 @@ pub(crate) fn get_changelog(
 
             // we don't use an HTTPS client or JSON parser to keep the build times low
             let pr = pr_num.to_string();
-            let pr_json =
-                cmd!(sh, "curl -s -H {accept} -H {authorization} {pr_url}/{pr}").read()?;
+            let Ok(pr_json) = cmd!(sh, "curl --fail -s -H {accept} -H {authorization} {pr_url}/{pr}").read() else { eprintln!("Cannot get info for #{pr}"); continue;};
             let pr_title = cmd!(sh, "jq .title").stdin(&pr_json).read()?;
             let pr_title = unescape(&pr_title[1..pr_title.len() - 1]);
             let pr_comment = cmd!(sh, "jq .body").stdin(pr_json).read()?;
 
             let comments_json =
-                cmd!(sh, "curl -s -H {accept} -H {authorization} {pr_url}/{pr}/comments").read()?;
+                cmd!(sh, "curl --fail -s -H {accept} -H {authorization} {pr_url}/{pr}/comments")
+                    .read()?;
             let pr_comments = cmd!(sh, "jq .[].body").stdin(comments_json).read()?;
 
             let l = iter::once(pr_comment.as_str())