Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate_enum_match doesn't work with generic params #7607

Closed
yoshuawuyts opened this issue Feb 9, 2021 · 1 comment · Fixed by #7617
Closed

generate_enum_match doesn't work with generic params #7607

yoshuawuyts opened this issue Feb 9, 2021 · 1 comment · Fixed by #7617
Labels
A-assists S-actionable Someone could pick this issue up and work on it right now

Comments

@yoshuawuyts
Copy link
Member 

enum Option<T> {
    Some(T),
    None,
}

This will fail to consider the generic in the resulting impl block. I know how to do the fix and can probably implement it after hours today.
@yoshuawuyts
Copy link
Member Author

Related: #7601, #7605

@Veykril Veykril added A-assists S-actionable Someone could pick this issue up and work on it right now labels Feb 9, 2021
@yoshuawuyts yoshuawuyts mentioned this issue Feb 9, 2021
Merged
@bors bors bot closed this as completed in 5e39d7a Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-assists S-actionable Someone could pick this issue up and work on it right now
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add getter/setter assists yoshuawuyts/rust-analyzer
2 participants
@yoshuawuyts @Veykril