Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal: Try to fix Code tests #10897

Merged
merged 4 commits into from Dec 1, 2021
Merged

internal: Try to fix Code tests #10897

merged 4 commits into from Dec 1, 2021

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented Dec 1, 2021

It looks like --noEmit broke our unit tests:

image

r? @ChayimFriedman2

I suppose we might still:

  • compile stuff twice
  • not detect failing tests on CI (since we didn't notice this)

@lnicola
Copy link
Member Author

lnicola commented Dec 1, 2021

CC #10688

@lnicola lnicola changed the title Try to fix Code tests internal: Try to fix Code tests Dec 1, 2021
@lnicola lnicola force-pushed the tests branch 2 times, most recently from cfc1771 to a04da1d Compare December 1, 2021 11:09
@lnicola
Copy link
Member Author

lnicola commented Dec 1, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 1, 2021

Build succeeded:

@bors bors bot merged commit af27958 into rust-lang:master Dec 1, 2021
@lnicola lnicola deleted the tests branch December 1, 2021 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@lnicola