Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: Replace mocha with a custom test runner #10903

Merged
merged 1 commit into from Dec 2, 2021
Merged

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented Dec 2, 2021

Closes #10723

r? @Aloso

@lnicola
Copy link
Member Author

lnicola commented Dec 2, 2021

The output looks like this:

image

image

I'm not sure about those empty newlines, they seem to be produced by console.log.

EDIT: with backtraces:

image

@lnicola lnicola changed the title Replace mocha with a custom test runner internal: Replace mocha with a custom test runner Dec 2, 2021
@bjorn3
Copy link
Member

bjorn3 commented Dec 2, 2021

For errors can you include a stacktrace?

@Aloso
Copy link

Aloso commented Dec 2, 2021

LGTM

I'm not sure about those empty newlines, they seem to be produced by console.log.

console.log only adds 1 line break. Something else is going on here, but since this is only a minor inconvenience, it isn't necessary to investigate.

@lnicola
Copy link
Member Author

lnicola commented Dec 2, 2021

bors r=Aloso

Fun fact: this yields a -1030 line diffstat on package-lock.json.

@bors
Copy link
Contributor

bors bot commented Dec 2, 2021

@bors bors bot merged commit 3b02aec into rust-lang:master Dec 2, 2021
@lnicola lnicola deleted the tea branch December 2, 2021 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop mocha as testing framework
3 participants