Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix lint completions not working for unclosed attributes #10986

Merged
merged 1 commit into from Dec 11, 2021
Merged

fix: Fix lint completions not working for unclosed attributes #10986

merged 1 commit into from Dec 11, 2021

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Dec 11, 2021

Fixes #10682
Uses keywords and nested TokenTrees as a heuristic to figure out when to stop parsing in case the attribute is unclosed which should work pretty well as attributes are usually followed by either of those.
bors r+

@bors
Copy link
Contributor

bors bot commented Dec 11, 2021

Build succeeded:

@bors bors bot merged commit 48cd733 into rust-lang:master Dec 11, 2021
@Veykril Veykril deleted the unclosed-attrs branch December 11, 2021 15:17
@iDawer iDawer mentioned this pull request Dec 15, 2021
Merged
bors bot added a commit that referenced this pull request Dec 20, 2021
@bors @iDawer
Merge #11028
f46731a 
11028: Bump MSRV (1.57) r=Veykril a=iDawer

This bumps MSRV on all crates to 1.57 except `la-arena`

#10986 requires >=1.57 

Co-authored-by: iDawer <ilnur.iskhakov.oss@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request: auto-complete for lints
1 participant
@Veykril