fix: Resolve private fields in type inference #11540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would do it a bit differently -- by doing field resolution again if the first attempt fails, allowing private fields in the second try. That way the fallback field will also be used for type inference. The same approach can be used for method resolution as well. But we can do this way for now, because I'm currently refactoring a lot around autoderef, so touching this code more would probably cause conflicts 😅 |
flodiebold
approved these changes
Feb 24, 2022
|
Ye, if you are touching this then we better change that later I agree 😄 bors r=flodiebold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10253 (comment)
(the same issue probably exists for method calls, but I think fixing that might be trickier)
Visibility checks were introduced in #7841 for autoderef to work properly, so now we just record the first field we find unconditionally, and then overwrite it if autoderef manages to find another field in a later cycle.