editors/code: fix crash due to missing ID= field #11710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assuming ID=linux in isNixOs by default. You can get away with default "", but why do that if there's a default value in spec?) Also removed toLowerCase — it really shouldn't be needed. Fixes rust-lang#11709
|
@lnicola I did goofed 😅 |
cab404
changed the title
lnicola
reviewed
Mar 15, 2022
| const idString = contents.split('\n').find((a) => a.startsWith("ID=")); | ||
| return idString?.toLowerCase()?.indexOf("nixos") !== -1; | ||
| const idString = contents.split('\n').find((a) => a.startsWith("ID=")) || "ID=linux"; | ||
| return idString.indexOf("nixos") !== -1; |
There was a problem hiding this comment.
Are you still sure you don't want this 😄?
Suggested change
| return idString.indexOf("nixos") !== -1; | |
| return contents.indexOf("nixos") !== -1; |
There was a problem hiding this comment.
I still kinda am — almost sure two-three years from now someone will find a way to trigger it accidentally :D
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assuming ID=linux by default.
Also removed toLowerCase — it really shouldn't be needed.
Fixes #11709