Use large stack on expander thread #12891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since you're there, can you also give the thread a name? And by the way, what does this thread do? |
|
Ah, 32ee097 |
|
Could also use a |
|
Er, I ran Edit: Nevermind, apparently I didn't and just thought I did. Sorry for the noise. |
lnicola
reviewed
Jul 27, 2022
umanwizard
force-pushed
the
expander_stack
branch
from
8662867
to
6f9bf85
Compare
umanwizard
force-pushed
the
expander_stack
branch
from
6f9bf85
to
f83738e
Compare
lnicola
reviewed
Jul 27, 2022
| .join(); | ||
| }) { | ||
| Ok(handle) => handle.join(), | ||
| Err(e) => std::panic::resume_unwind(Box::new(e)), |
There was a problem hiding this comment.
I might be missing something, but wouldn't unwrap be fine here?
Sorry for all the nitpicks.
There was a problem hiding this comment.
Does that still apply if this is a simple io::Error? I'd have to test.
|
@bors delegate+ |
|
✌️ @brennanvincent can now approve this pull request |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have verified that this fixes #12884 for me.
Hat tip to @bjorn3 for identifying the cause of the issue.