Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure find_path into a separate functions for modules and non-module items #13227

Merged
merged 1 commit into from Sep 13, 2022

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Sep 13, 2022

Follow up to #13212
Also renames prefer_core imports config to prefer_no_std and changes the behavior of no_std path searching by preferring core paths over alloc

This PR turned into a slight rewrite, so it unfortunately does a few more things that I initially planned to (including a bug fix for enum variant paths)

@Veykril
Copy link
Member Author

Veykril commented Sep 13, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 13, 2022

📌 Commit cb00af0 has been approved by Veykril

It is now in the queue for this repository.

bors added a commit that referenced this pull request Sep 13, 2022
When prefer-core is set, invert find path std crate preference

Follow up to #13212, `prefer-core` usually implies that one wants to have the std imports from the defining crate over the re-export.
@bors
Copy link
Collaborator

bors commented Sep 13, 2022

⌛ Testing commit cb00af0 with merge 6b6c05c...

@bors
Copy link
Collaborator

bors commented Sep 13, 2022

💔 Test failed - checks-actions

…-module items

Also renames `prefer_core` imports config to `prefer_no_std` and changes the behavior of no_std path searching by preferring `core` paths `over` alloc
@Veykril Veykril changed the title When prefer-core is set, invert find path std crate preference Restructure find_path into a separate functions for modules and non-module items Sep 13, 2022
@Veykril Veykril changed the title Restructure find_path into a separate functions for modules and non-module items Restructure find_path into a separate functions for modules and non-module items Sep 13, 2022
@Veykril
Copy link
Member Author

Veykril commented Sep 13, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 13, 2022

📌 Commit a8ecaa1 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Sep 13, 2022

⌛ Testing commit a8ecaa1 with merge 125d43c...

@bors
Copy link
Collaborator

bors commented Sep 13, 2022

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 125d43c to master...

@bors bors merged commit 125d43c into rust-lang:master Sep 13, 2022
@Veykril Veykril deleted the core-pref branch September 13, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants