feat: Add an option to hide adjustment hints outside of unsafe blocks and functions
#13817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
WaffleLapkin
commented
Dec 21, 2022
| @@ -110,6 +121,59 @@ pub(super) fn hints( | |||
| Some(()) | |||
| } | |||
|
|
|||
| fn is_inside_unsafe(sema: &Semantics<'_, RootDatabase>, node: &SyntaxNode) -> bool { | |||
There was a problem hiding this comment.
This seems to be working fine, but I'm left wondering if there is a better way...
Veykril
reviewed
Dec 21, 2022
crates/hir/src/semantics.rs
Outdated
| @@ -1458,6 +1470,59 @@ impl<'db> SemanticsImpl<'db> { | |||
| .map(|ty| ty.original.is_packed(self.db)) | |||
| .unwrap_or(false) | |||
| } | |||
|
|
|||
| fn is_inside_unsafe(&self, node: &SyntaxNode) -> bool { | |||
There was a problem hiding this comment.
Suggested change
| fn is_inside_unsafe(&self, node: &SyntaxNode) -> bool { | |
| fn is_inside_unsafe(&self, node: &ast::Expr)-> bool { |
This handles expressions so it should only take such
rust-cloud-vms
bot
force-pushed
the
hide_adjustment_hints_outside_of_unsafe
branch
from
bb3a66b
to
94d0772
Compare
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
rust-cloud-vms
bot
force-pushed
the
hide_adjustment_hints_outside_of_unsafe
branch
from
94d0772
to
1038db5
Compare
|
This might not play completely nice with macro expansions, but we'll see |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title suggests: this PR adds an option (namely
rust-analyzer.inlayHints.expressionAdjustmentHints.hideOutsideUnsafe) that allows to hide adjustment hints outside ofunsafeblocks and functions:Requested by @BoxyUwU <3