Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show signature help when typing record literal #14041

Merged
merged 2 commits into from Jan 27, 2023
Merged

feat: show signature help when typing record literal #14041

merged 2 commits into from Jan 27, 2023

Conversation

jonas-schievink
Copy link
Contributor

Closes #13910

Screenshot_20230127_191848

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 27, 2023
@Veykril
Copy link
Member

Veykril commented Jan 27, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 27, 2023

📌 Commit cad4cb3 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jan 27, 2023

⌛ Testing commit cad4cb3 with merge f1b257f...

@bors
Copy link
Collaborator

bors commented Jan 27, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing f1b257f to master...

@bors bors merged commit f1b257f into rust-lang:master Jan 27, 2023
@jonas-schievink jonas-schievink deleted the record-lit-signature-help branch January 27, 2023 22:25
@wasd96040501
Copy link
Contributor

@jonas-schievink Can you implement this #13977? It seems similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Signature help for struct, union and enum variant literals
5 participants