Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: clean api to get raw_ptr type #14213

Merged
merged 2 commits into from Feb 27, 2023
Merged

Conversation

swarnimarun
Copy link
Contributor

@swarnimarun swarnimarun commented Feb 27, 2023

There doesn't seem to be an API to fetch the type of raw_ptr, which is helpful for a project I work on.

Notes:

  • I am unsure about the function name, do let me know if I should use something else.
  • Also unsure about where to add tests, for hir changes. Will fix it as needed.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 27, 2023
crates/hir/src/lib.rs Outdated Show resolved Hide resolved
@Veykril
Copy link
Member

Veykril commented Feb 27, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 27, 2023

📌 Commit 832f8bf has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Feb 27, 2023

⌛ Testing commit 832f8bf with merge b38fcde...

@bors
Copy link
Collaborator

bors commented Feb 27, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing b38fcde to master...

1 similar comment
@bors
Copy link
Collaborator

bors commented Feb 27, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing b38fcde to master...

@bors
Copy link
Collaborator

bors commented Feb 27, 2023

👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.

@bors bors merged commit b38fcde into rust-lang:master Feb 27, 2023
@swarnimarun swarnimarun deleted the raw-ptr-ty branch February 27, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants